feat(search-bar): Add consent flow to Ask Seer #95406

nsdeschenes · 2025-07-13T18:39:20Z

This PR adds in the consent flow for Ask Seer, as well as the associated tests for these changes. This enables users to turn on Ask Seer to help them generate queries while searching on the explore/traces page.

Ticket: AIML-704

codecov · 2025-07-13T18:44:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #95406   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files       10563    10563           
  Lines      608782   608753   -29     
  Branches    23912    23908    -4     
=======================================
- Hits       526614   526591   -23     
+ Misses      81873    81868    -5     
+ Partials      295      294    -1

static/app/components/searchQueryBuilder/askSeer.tsx

nsdeschenes · 2025-07-14T08:11:47Z

Bug: Ask Seer Options Incorrectly Displayed

The useHiddenItems logic in combobox.tsx incorrectly hides only one of the Ask Seer options (ASK_SEER_ITEM_KEY or ASK_SEER_CONSENT_ITEM_KEY) based on the gaveSeerConsent status. Both of these options should always be hidden from the main list of results, as the appropriate Ask Seer prompt is rendered separately by the AskSeer component. This can lead to the wrong Ask Seer option appearing as a duplicate in the main list.

static/app/components/searchQueryBuilder/tokens/combobox.tsx#L193-L200
Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

This is incorrect, and actually caused a bug.

const openState = isOpen ?? state.isOpen;

if (hasCustomMenu) {
  return openState;
}

// When a custom menu is not being displayed and we aren't loading anything,
// only show when there is something to select from.
return openState && totalOptions > hiddenOptions.size;

We need to only add one of the two, or else when searching free text, the condition will never be met properly. I attempted to switch from > to >= however this raised issues when free text is not allowed.

roaga

You also should not be showing any Seer UI, not even the consent entry point, if organization.hideAiFeatures is true

static/app/components/searchQueryBuilder/askSeer.tsx

static/app/components/searchQueryBuilder/askSeer.spec.tsx

malwilley · 2025-07-14T18:27:52Z

static/app/components/searchQueryBuilder/askSeer.tsx

+          {
+            dataProcessingPolicy: (
+              <TooltipSubExternalLink
+                onMouseOver={() => setOptionDisableOverride(true)}


Are you disabling to prevent the click here from propagating to the option?

In other areas, I've added stopPropagation to the necessary handlers to prevent the click from going through:

sentry/static/app/components/searchQueryBuilder/tokens/filter/valueCombobox.tsx

Lines 501 to 505 in 119d3f3

<TrailingWrap

onPointerUp={e => e.stopPropagation()}

onMouseUp={e => e.stopPropagation()}

onClick={e => e.stopPropagation()}

>

Yes, exactly. The reason why this is needed is because of the logic that lives inside these lines: https://github.com/getsentry/sentry/blob/nd/AIML-704/feat-add-consent-flow-to-trace-ask-seer/static/app/components/searchQueryBuilder/tokens/filterKeyListBox/useFilterKeyListBox.tsx#L388-L404, there doesn't seem to be any way to access the event in this handler, so can't call stopPropagation, there it would seem

As the onClick handler in askSeer.tsx isn't used.

You can still add onMouseUp={e => e.stopPropagation()} (and others if necessary) to the <TooltipSubExternalLink> though right? That would prevent the option from being selected when you click the link

No that doesn't work annoyingly, it's still triggering the option via useFilterKeyListBox

nsdeschenes · 2025-07-15T07:07:42Z

You also should not be showing any Seer UI, not even the consent entry point, if organization.hideAiFeatures is true

Yep, any cases of where <AskSeer> is being called is checked to see if enableAiSearch is true, which does check to ensure that organization.hideAiFeatures is false.

https://github.com/getsentry/sentry/blob/nd/AIML-704/feat-add-consent-flow-to-trace-ask-seer/static/app/components/searchQueryBuilder/context.tsx#L107-L108

…triggered

…xt issue

…y selection dropdown

static/app/components/searchQueryBuilder/askSeer.tsx

cursor

Bug: Ask Seer Options Incorrectly Displayed

The useHiddenItems hook in combobox.tsx incorrectly hides only one of the Ask Seer options (ASK_SEER_ITEM_KEY or ASK_SEER_CONSENT_ITEM_KEY) based on the gaveSeerConsent status. Both options should always be hidden from the main dropdown list, as the appropriate Ask Seer prompt is rendered separately by the AskSeer component. This causes the wrong Ask Seer option to appear as a duplicate in the main results list.

static/app/components/searchQueryBuilder/tokens/combobox.tsx#L192-L200

sentry/static/app/components/searchQueryBuilder/tokens/combobox.tsx

Lines 192 to 200 in bb15ff3

    
           ); 
        
           if (showAskSeerOption) { 
        
             if (gaveSeerConsent) { 
        
               options.add(ASK_SEER_ITEM_KEY); 
        
             } else { 
        
               options.add(ASK_SEER_CONSENT_ITEM_KEY); 
        
             } 
        
           }

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

nsdeschenes requested review from aayush-se and roaga July 13, 2025 18:39

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 13, 2025

nsdeschenes requested a review from malwilley July 14, 2025 06:01

vercel bot deployed to Preview July 14, 2025 06:25 View deployment

nsdeschenes marked this pull request as ready for review July 14, 2025 06:56

This comment was marked as outdated.

Sign in to view

TkDodo reviewed Jul 14, 2025

View reviewed changes

static/app/components/searchQueryBuilder/askSeer.tsx Outdated Show resolved Hide resolved

static/app/components/searchQueryBuilder/askSeer.tsx Outdated Show resolved Hide resolved

nsdeschenes requested a review from a team as a code owner July 14, 2025 07:31

vercel bot deployed to Preview July 14, 2025 07:33 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview July 14, 2025 07:48 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview July 14, 2025 08:03 View deployment

This comment was marked as outdated.

Sign in to view

nsdeschenes force-pushed the nd/AIML-704/feat-add-consent-flow-to-trace-ask-seer branch from 2a0d2b3 to b499912 Compare July 14, 2025 11:32

vercel bot deployed to Preview July 14, 2025 11:33 View deployment

This comment was marked as outdated.

Sign in to view

roaga reviewed Jul 14, 2025

View reviewed changes

static/app/components/searchQueryBuilder/askSeer.tsx Outdated Show resolved Hide resolved

malwilley reviewed Jul 14, 2025

View reviewed changes

vercel bot deployed to Preview July 15, 2025 07:23 View deployment

nsdeschenes force-pushed the nd/AIML-704/feat-add-consent-flow-to-trace-ask-seer branch from b969f87 to 7797141 Compare July 15, 2025 07:29

vercel bot deployed to Preview July 15, 2025 07:31 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview July 15, 2025 07:46 View deployment

nsdeschenes requested review from malwilley and roaga July 16, 2025 12:21

nsdeschenes added 20 commits July 16, 2025 12:55

👔 Move all AskSeer related items into askSeer.tsx

6efa20c

👔 Add consent_accepted action to ai_query_interface analytics

884eb10

👔 Add gaveSeerConsentRef to SearchQueryBuilderContext

dc1edcf

👔 Ignore ask-seer-consent when freeText onOptionSelected callback is …

cb8e640

…triggered

👔 Add ask-seer-consent items to lists

02c78b8

✅ Update search query builder tests

67ec4ac

👔 Add in AskSeerConsent flow to askSeer.tsx

bec4db5

✅ Add in tests for askSeer

b80b69e

👔 Move acknowledgement mutation into it's own custom hook

fbfcd52

👔 Conditionally add options to hidden items to resolve disallowFreeTe…

ee0894d

…xt issue

👔 Utilize acknowledgement hook when selecting ask seer option from ke…

f69c2ef

…y selection dropdown

👔 Grab consent status directly in context and pass down

27152e9

👔 Move disable option logic directly onto react event listeners

b23f876

👔 Check if query is fetching using query key

631bc6f

🐛 Remove extra array layering

d3013d0

👔 Enable query only if AI features are enabled

d3e242f

🚚 Move seer acknowledgement mutation into it's own file

3c6942f

🐛 Fix import issue

32bcc5b

✅ Fix tests

b5c2e48

✅ Move all tests to index.spec.tsx

4eb8681

nsdeschenes force-pushed the nd/AIML-704/feat-add-consent-flow-to-trace-ask-seer branch from d3bd864 to 4eb8681 Compare July 16, 2025 17:33

vercel bot deployed to Preview July 16, 2025 17:35 View deployment

This comment was marked as outdated.

Sign in to view

malwilley reviewed Jul 16, 2025

View reviewed changes

static/app/components/searchQueryBuilder/askSeer.tsx Outdated Show resolved Hide resolved

nsdeschenes added 2 commits July 16, 2025 14:10

👔 Remove onClick handler, and move to using theme spacing

6cdaf88

✅ Fix up broken test ... in an interesting way

bb15ff3

vercel bot deployed to Preview July 16, 2025 19:08 View deployment

cursor bot reviewed Jul 16, 2025

View reviewed changes

nsdeschenes requested a review from malwilley July 16, 2025 20:43

malwilley approved these changes Jul 16, 2025

View reviewed changes

	<TrailingWrap
	onPointerUp={e => e.stopPropagation()}
	onMouseUp={e => e.stopPropagation()}
	onClick={e => e.stopPropagation()}
	>

	);

	if (showAskSeerOption) {
	if (gaveSeerConsent) {
	options.add(ASK_SEER_ITEM_KEY);
	} else {
	options.add(ASK_SEER_CONSENT_ITEM_KEY);
	}
	}

Uh oh!

feat(search-bar): Add consent flow to Ask Seer #95406

Are you sure you want to change the base?

feat(search-bar): Add consent flow to Ask Seer #95406

Uh oh!

Conversation

nsdeschenes commented Jul 13, 2025

Uh oh!

codecov bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

nsdeschenes commented Jul 14, 2025

Bug: Ask Seer Options Incorrectly Displayed

Uh oh!

This comment was marked as outdated.

Uh oh!

roaga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

malwilley Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

nsdeschenes Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malwilley Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

nsdeschenes Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

nsdeschenes commented Jul 15, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Ask Seer Options Incorrectly Displayed

Uh oh!

Uh oh!

codecov bot commented Jul 13, 2025 •

edited

Loading

nsdeschenes Jul 15, 2025 •

edited

Loading